-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add architecture explanation page #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as usual! I have some things for you to consider before approving the PR.
There are discussions about using "Ubuntu on WSL". These discussions are not mature, however, and we should not use the new terminology without achieving consensus.
7266d44
to
f15aef4
Compare
Thanks for the review and your insightful comments @CarlosNihelton . I reverted to "Ubuntu WSL" in 77b116a, applied your suggestions to the explanation in 19e1447 and the ones for the reference in f15aef4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
In d03d56e a dedicated explanation section that includes a page describing the architecture of UP4W and its components.
Previously, UP4W components and other topics (WSL and registry) where small, self-contained pages in the reference section.
The explanation attempts to describe the individual components but also make connections between those components, so that the reader can better understand the software as a whole.
In 26c7c28 a glossary of system components is included as a separate reference page. This can be quickly scanned for information about the major components, providing basic descriptions and any relevant commands.
NOTE: these sections could be better linked with the rest of the documentation, but I want to wait until we merge the Ubuntu WSL documentation with this repo because that will involve some restructuring.
The following commits address comments raised by @CarlosNihelton in PR 981:
Other minor changes include:
UDENG-5517