Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add architecture explanation page #1012

Merged
merged 11 commits into from
Dec 13, 2024
Merged

docs: add architecture explanation page #1012

merged 11 commits into from
Dec 13, 2024

Conversation

edibotopic
Copy link
Collaborator

@edibotopic edibotopic commented Dec 11, 2024

In d03d56e a dedicated explanation section that includes a page describing the architecture of UP4W and its components.
Previously, UP4W components and other topics (WSL and registry) where small, self-contained pages in the reference section.
The explanation attempts to describe the individual components but also make connections between those components, so that the reader can better understand the software as a whole.

In 26c7c28 a glossary of system components is included as a separate reference page. This can be quickly scanned for information about the major components, providing basic descriptions and any relevant commands.

NOTE: these sections could be better linked with the rest of the documentation, but I want to wait until we merge the Ubuntu WSL documentation with this repo because that will involve some restructuring.

The following commits address comments raised by @CarlosNihelton in PR 981:

  • 5d65a56 adds a note about potential references to outdated Go versions
  • 7ee851d references a command that can be used to start the Windows agent from the terminal

Other minor changes include:

UDENG-5517

@edibotopic edibotopic marked this pull request as ready for review December 11, 2024 13:23
@edibotopic edibotopic requested a review from a team as a code owner December 11, 2024 13:23
Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual! I have some things for you to consider before approving the PR.

docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/explanation/ref-arch-explanation.md Outdated Show resolved Hide resolved
docs/reference/glossary_up4w_components.md Outdated Show resolved Hide resolved
docs/reference/glossary_up4w_components.md Outdated Show resolved Hide resolved
docs/reference/09-qa-process-reference.md Show resolved Hide resolved
@edibotopic
Copy link
Collaborator Author

Thanks for the review and your insightful comments @CarlosNihelton .

I reverted to "Ubuntu WSL" in 77b116a, applied your suggestions to the explanation in 19e1447 and the ones for the reference in f15aef4.

Copy link
Contributor

@CarlosNihelton CarlosNihelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@edibotopic edibotopic merged commit 1fb10f7 into main Dec 13, 2024
3 checks passed
@edibotopic edibotopic deleted the ref-arch-explanation branch December 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants